Add Gemma4 EAGLE-3 hidden-state taps#20150
Draft
digantdesai wants to merge 1 commit into
Draft
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20150
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 57ef8a5 with merge base dc55469 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Jun 9, 2026
metascroy
reviewed
Jun 9, 2026
| self, | ||
| tokens: torch.LongTensor, | ||
| input_pos: torch.LongTensor, | ||
| last_logits_only: bool = True, |
Contributor
There was a problem hiding this comment.
For tapped model, do we need all logits, not just final so sampling can be done outside model?
If so, why is last_logits_only default to True on forward_logits_taps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validated tap-layer configuration, a shared decode path that can
return concatenated tap features, and forward_logits_taps for
soft-capped logits with EAGLE-3 features. Includes tests for tap
ordering, validation, logits parity, and last-logits behavior.
Authored with assistance from Claude Code.